Remove passive task resend logic #6906
Open
+143
−658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
reviewed
Dec 4, 2024
| registry namespace.Registry, | ||
| ) bool { | ||
| workflowKey := taskWorkflowKey(taskInfo) | ||
| remoteClusterName, err := getRemoteClusterName( |
There was a problem hiding this comment.
nit: sourceCluster to match the method name?
| if err != nil { | ||
| return true | ||
| } | ||
| _, err = remoteAdminClient.DescribeMutableState(ctx, &adminservice.DescribeMutableStateRequest{ |
There was a problem hiding this comment.
Could we use DescribeWorkflowExecution?
| @@ -166,7 +160,7 @@ func (t *timerQueueStandbyTaskExecutor) executeUserTimerTimeoutTask( | |||
| timerTask.GetVisibilityTime(), | |||
| timerSequenceID.Timestamp, | |||
| ) { | |||
| return getHistoryResendInfo(mutableState) | |||
| return &struct{}{}, nil | |||
There was a problem hiding this comment.
nit: seem like we don't need extra data in the struct. could we just use a boolean?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Remove passive task resend logic
Why?
Resend is best effort
How did you test it?
unit test
Potential risks
passive task may disappear
Documentation
no document
Is hotfix candidate?
no